use noOp cache instead of null when instantiating typedSparkeySideInput #5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5469 +/- ##
==========================================
- Coverage 61.31% 61.30% -0.01%
==========================================
Files 312 312
Lines 11068 11070 +2
Branches 792 773 -19
==========================================
+ Hits 6786 6787 +1
- Misses 4282 4283 +1 ☔ View full report in Codecov by Sentry. |
RustedBones
reviewed
Sep 4, 2024
scio-extra/src/main/scala/com/spotify/scio/extra/sparkey/package.scala
Outdated
Show resolved
Hide resolved
RustedBones
reviewed
Sep 5, 2024
scio-extra/src/main/scala/com/spotify/scio/extra/sparkey/package.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to access an element in a side input instantiated by
typedSparkeySideInputwherecacheisn't specified, the following error is thrown since the cache is explicitly set to null: